Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add unit test for localeNotification in workbench #398

Merged
merged 1 commit into from
Sep 3, 2021
Merged

test: add unit test for localeNotification in workbench #398

merged 1 commit into from
Sep 3, 2021

Conversation

mortalYoung
Copy link
Collaborator

Description

  • Add unit test for for the localeNotification component in workbench

@mortalYoung mortalYoung added the unit test The PR is for the unit test mainly label Sep 3, 2021
@mortalYoung mortalYoung added this to the 0.9.0-alpha.5 milestone Sep 3, 2021
@mortalYoung mortalYoung self-assigned this Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #398 (5f5e2d8) into main (d43dee4) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   78.81%   78.92%   +0.10%     
==========================================
  Files         176      176              
  Lines        4844     4844              
  Branches     1044     1044              
==========================================
+ Hits         3818     3823       +5     
+ Misses       1019     1014       -5     
  Partials        7        7
Impacted Files Coverage Δ
...tification/notificationPane/localeNotification.tsx 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d43dee4...5f5e2d8. Read the comment docs.

wewoor
wewoor approved these changes Sep 3, 2021
View reviewed changes
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit e5971b7 into main Sep 3, 2021
@wewoor wewoor deleted the test/localNotification branch September 3, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wewoor wewoor wewoor approved these changes

Assignees

@mortalYoung mortalYoung

Labels
unit test The PR is for the unit test mainly
Projects
None yet
Milestone
0.9.0-alpha.5
Development

Successfully merging this pull request may close these issues.
2 participants
@mortalYoung @wewoor